linux-kernel - RE: Re: [PATCH] PM / devfreq: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170706013947epcms1p3be4b0f009cb73ccf8d555c9e6d1c529d@epcms1p3>
Date:   Thu, 06 Jul 2017 01:39:47 +0000
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Kyungmin Park <kyungmin.park@...sung.com>
CC:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH] PM / devfreq: constify attribute_group structures.

> On 2017년 07월 03일 19:10, Arvind Yadav wrote:
> > attribute_groups are not supposed to change at runtime. All functions
> > working with attribute_groups provided by <linux/sysfs.h> work with const
> > attribute_group. So mark the non-const structs as const.
> > 
> > File size before:
> >    text	   data	    bss	    dec	    hex	filename
> >     621	    176	      0	    797	    31d	drivers/devfreq/governor_userspace.o
> > 
> > File size After adding 'const':
> >    text	   data	    bss	    dec	    hex	filename
> >    670	    144	      0	    814	    32e	drivers/devfreq/governor_userspace.o
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> > ---
> >  drivers/devfreq/governor_userspace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
[]
> 
> Looks good to me.
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

Thank you. Applying to for-rc branch.


Cheers,
MyungJoo