linux-kernel - Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <740ccb0a99eb927fb02965018b7d1619@codeaurora.org>
Date:   Thu, 06 Jul 2017 15:51:57 +0530
From:   kgunda@...eaurora.org
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
        David Collins <collinsd@...eaurora.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Fenglin Wu <fenglinw@...eaurora.org>,
        linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less
 than 0

On 2017-07-06 12:23, Stephen Boyd wrote:
> On 07/03, Kiran Gunda wrote:
>> From: Fenglin Wu <fenglinw@...eaurora.org>
>> 
>> The opc parameter in pmic_arb_write_cmd() function is defined with 
>> type
>> u8 and it's always greater than or equal to 0. Checking that it's not
>> less than 0 is redundant and it can cause a forbidden warning during
>> compilation. Remove the check.
>> 
>> Signed-off-by: Fenglin Wu <fenglinw@...eaurora.org>
>> ---
> 
> You forgot your sign-off here.
yeah.. forgot. Will add it.