linux-kernel - Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f9393918c769877d28754036596fac1@codeaurora.org>
Date:   Thu, 06 Jul 2017 16:00:22 +0530
From:   kgunda@...eaurora.org
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
        Nicholas Troast <ntroast@...eaurora.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi
 irq wakeup capability

On 2017-07-06 12:16, Stephen Boyd wrote:
> On 07/03, Kiran Gunda wrote:
>> diff --git a/drivers/spmi/spmi-pmic-arb.c 
>> b/drivers/spmi/spmi-pmic-arb.c
>> index 5285245..2d2e39c 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data 
>> *d, unsigned int flow_type)
>>  	return 0;
>>  }
>> 
>> +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
>> +{
>> +	struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
>> +	int ret;
>> +
>> +	if (on)
>> +		ret = enable_irq_wake(pmic_arb->irq);
>> +	else
>> +		ret = disable_irq_wake(pmic_arb->irq);
> 
> Could be simplified to
> 
> 	return irq_set_irq_wake(pmic_arb->irq, on);
> 
> ?
> 
yes. Will modify it.
>> +
>> +	return ret;
>> +}
>> +
>>  static int qpnpint_get_irqchip_state(struct irq_data *d,
>>  				     enum irqchip_irq_state which,
>>  				     bool *state)