lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Jul 2017 15:55:57 +0200 From: Andrew Lunn <andrew@...n.ch> To: Richard Leitner <richard.leitner@...data.com> Cc: fugang.duan@....com, robh+dt@...nel.org, mark.rutland@....com, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, dev@...l1n.net Subject: Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option Hi Richard > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt > index 6f55bdd..1766579 100644 > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt > @@ -23,6 +23,9 @@ Optional properties: > - phy-handle : phandle to the PHY device connected to this device. > - fixed-link : Assume a fixed link. See fixed-link.txt in the same directory. > Use instead of phy-handle. > +- phy-reset-after-clk-enable : If present then a phy reset and configuration > + will be performed everytime after the clocks are enabled. This is required > + for some PHYs to work properly. It sounds like this issue will apply to any LAN8710 which has its clock fiddled with. So this should be a centrally documented property, which any MAC driver can implement. Please move the above text to ethernet.txt, and instead have: - phy-reset-after-clk-enable : See ethernet.txt Thanks Andrew
Powered by blists - more mailing lists