lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 7 Jul 2017 03:00:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Gaurav Pathak <gauravpathak129@...il.com>
Cc:     kbuild-all@...org, joe@...ches.com, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org,
        Gaurav Pathak <gauravpathak129@...il.com>
Subject: Re: [PATCH] staging: rts5208: Replace embedded function names with
 "%s: ", __func__

Hi Gaurav,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.12 next-20170706]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gaurav-Pathak/staging-rts5208-Replace-embedded-function-names-with-s-__func__/20170706-131957
config: i386-randconfig-c0-07070124 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/staging/rts5208/sd.c: In function 'sd_check_switch_mode':
   drivers/staging/rts5208/sd.c:1228:26: warning: missing terminating " character
     dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d,
                             ^
   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
   include/linux/dynamic_debug.h:74:16: error: missing terminating " character
     static struct _ddebug  __aligned(8)   \
                   ^
   include/linux/dynamic_debug.h:98:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
     DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_false, \
     ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:1228:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d,
     ^
   drivers/staging/rts5208/sd.c:1229:20: error: expected expression before '%' token
      func_to_switch = %d)\n", __func__, mode, func_group,
                       ^
   include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
      .format = (fmt),    \
                 ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:1228:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d,
     ^
   In file included from include/linux/dynamic_debug.h:5:0,
                    from include/linux/printk.h:329,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
>> include/linux/jump_label.h:391:59: error: missing terminating " character
     else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
                                                              ^
   include/linux/dynamic_debug.h:102:2: note: in expansion of macro 'static_branch_unlikely'
     static_branch_unlikely(&descriptor.key.dd_key_false)
     ^
   include/linux/dynamic_debug.h:133:6: note: in expansion of macro 'DYNAMIC_DEBUG_BRANCH'
     if (DYNAMIC_DEBUG_BRANCH(descriptor))   \
         ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:1228:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d,
     ^
   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
   drivers/staging/rts5208/sd.c:1229:20: error: expected expression before '%' token
      func_to_switch = %d)\n", __func__, mode, func_group,
                       ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^
   drivers/staging/rts5208/sd.c:1228:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d,
     ^
   drivers/staging/rts5208/sd.c:1229:20: error: stray '\' in program
      func_to_switch = %d)\n", __func__, mode, func_group,
                       ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^
   drivers/staging/rts5208/sd.c:1228:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d,
     ^
   drivers/staging/rts5208/sd.c:1229:24: error: expected ';' before 'n'
      func_to_switch = %d)\n", __func__, mode, func_group,
                           ^
   drivers/staging/rts5208/sd.c:1229:25: warning: missing terminating " character
      func_to_switch = %d)\n", __func__, mode, func_group,
                            ^
   drivers/staging/rts5208/sd.c:1229:24: error: missing terminating " character
      func_to_switch = %d)\n", __func__, mode, func_group,
                           ^
   drivers/staging/rts5208/sd.c: In function 'sd_execute_write_data':
   drivers/staging/rts5208/sd.c:5041:27: warning: missing terminating " character
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
                              ^
   drivers/staging/rts5208/sd.c:5042:37: warning: missing terminating " character
        sd_card->sd_lock_status = 0x%x\n",
                                        ^
   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
   include/linux/dynamic_debug.h:74:16: error: missing terminating " character
     static struct _ddebug  __aligned(8)   \
                   ^
   include/linux/dynamic_debug.h:98:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
     DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_false, \
     ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   drivers/staging/rts5208/sd.c:5042:31: error: invalid suffix "x" on integer constant
        sd_card->sd_lock_status = 0x%x\n",
                                  ^
   include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
      .format = (fmt),    \
                 ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   include/linux/dynamic_debug.h:74:16: error: stray '\' in program
     static struct _ddebug  __aligned(8)   \
                   ^
   include/linux/dynamic_debug.h:98:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
     DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_false, \
     ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   drivers/staging/rts5208/sd.c:5042:34: error: 'x' undeclared (first use in this function)
        sd_card->sd_lock_status = 0x%x\n",
                                     ^
   include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
      .format = (fmt),    \
                 ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   drivers/staging/rts5208/sd.c:5042:34: note: each undeclared identifier is reported only once for each function it appears in
        sd_card->sd_lock_status = 0x%x\n",
                                     ^
   include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
      .format = (fmt),    \
                 ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   drivers/staging/rts5208/sd.c:5042:36: error: expected ')' before 'n'
        sd_card->sd_lock_status = 0x%x\n",
                                       ^
   include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
      .format = (fmt),    \
                 ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   drivers/staging/rts5208/sd.c:5042:36: error: missing terminating " character
        sd_card->sd_lock_status = 0x%x\n",
                                       ^
   include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
      .format = (fmt),    \
                 ^
   include/linux/dynamic_debug.h:132:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   In file included from include/linux/dynamic_debug.h:5:0,
                    from include/linux/printk.h:329,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
>> include/linux/jump_label.h:391:59: error: missing terminating " character
     else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
                                                              ^
   include/linux/dynamic_debug.h:102:2: note: in expansion of macro 'static_branch_unlikely'
     static_branch_unlikely(&descriptor.key.dd_key_false)
     ^
   include/linux/dynamic_debug.h:133:6: note: in expansion of macro 'DYNAMIC_DEBUG_BRANCH'
     if (DYNAMIC_DEBUG_BRANCH(descriptor))   \
         ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
   drivers/staging/rts5208/sd.c:5042:31: error: invalid suffix "x" on integer constant
        sd_card->sd_lock_status = 0x%x\n",
                                  ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   In file included from include/linux/dynamic_debug.h:5:0,
                    from include/linux/printk.h:329,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
   include/linux/jump_label.h:391:59: error: stray '\' in program
     else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
                                                              ^
   include/linux/dynamic_debug.h:102:2: note: in expansion of macro 'static_branch_unlikely'
     static_branch_unlikely(&descriptor.key.dd_key_false)
     ^
   include/linux/dynamic_debug.h:133:6: note: in expansion of macro 'DYNAMIC_DEBUG_BRANCH'
     if (DYNAMIC_DEBUG_BRANCH(descriptor))   \
         ^
   include/linux/device.h:1320:2: note: in expansion of macro 'dynamic_dev_dbg'
     dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \
     ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:13,
                    from arch/x86/include/asm/percpu.h:44,
                    from arch/x86/include/asm/current.h:5,
                    from include/linux/sched.h:11,
                    from include/linux/blkdev.h:4,
                    from drivers/staging/rts5208/sd.c:23:
   drivers/staging/rts5208/sd.c:5042:36: error: expected ')' before 'n'
        sd_card->sd_lock_status = 0x%x\n",
                                       ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
   drivers/staging/rts5208/sd.c:5042:36: error: missing terminating " character
        sd_card->sd_lock_status = 0x%x\n",
                                       ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^
   drivers/staging/rts5208/sd.c:5041:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(rtsx_dev(chip), "sd_lock_state = 0x%x,
      ^
..

vim +391 include/linux/jump_label.h

11276d53 Peter Zijlstra 2015-07-24  375  ({										\
11276d53 Peter Zijlstra 2015-07-24  376  	bool branch;								\
11276d53 Peter Zijlstra 2015-07-24  377  	if (__builtin_types_compatible_p(typeof(*x), struct static_key_true))	\
11276d53 Peter Zijlstra 2015-07-24  378  		branch = !arch_static_branch(&(x)->key, true);			\
11276d53 Peter Zijlstra 2015-07-24  379  	else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
11276d53 Peter Zijlstra 2015-07-24  380  		branch = !arch_static_branch_jump(&(x)->key, true);		\
11276d53 Peter Zijlstra 2015-07-24  381  	else									\
11276d53 Peter Zijlstra 2015-07-24  382  		branch = ____wrong_branch_error();				\
11276d53 Peter Zijlstra 2015-07-24  383  	branch;									\
11276d53 Peter Zijlstra 2015-07-24  384  })
11276d53 Peter Zijlstra 2015-07-24  385  
11276d53 Peter Zijlstra 2015-07-24  386  #define static_branch_unlikely(x)						\
11276d53 Peter Zijlstra 2015-07-24  387  ({										\
11276d53 Peter Zijlstra 2015-07-24  388  	bool branch;								\
11276d53 Peter Zijlstra 2015-07-24  389  	if (__builtin_types_compatible_p(typeof(*x), struct static_key_true))	\
11276d53 Peter Zijlstra 2015-07-24  390  		branch = arch_static_branch_jump(&(x)->key, false);		\
11276d53 Peter Zijlstra 2015-07-24 @391  	else if (__builtin_types_compatible_p(typeof(*x), struct static_key_false)) \
11276d53 Peter Zijlstra 2015-07-24  392  		branch = arch_static_branch(&(x)->key, false);			\
11276d53 Peter Zijlstra 2015-07-24  393  	else									\
11276d53 Peter Zijlstra 2015-07-24  394  		branch = ____wrong_branch_error();				\
11276d53 Peter Zijlstra 2015-07-24  395  	branch;									\
11276d53 Peter Zijlstra 2015-07-24  396  })
11276d53 Peter Zijlstra 2015-07-24  397  
11276d53 Peter Zijlstra 2015-07-24  398  #else /* !HAVE_JUMP_LABEL */
11276d53 Peter Zijlstra 2015-07-24  399  

:::::: The code at line 391 was first introduced by commit
:::::: 11276d5306b8e5b438a36bbff855fe792d7eaa61 locking/static_keys: Add a new static_key interface

:::::: TO: Peter Zijlstra <peterz@...radead.org>
:::::: CC: Ingo Molnar <mingo@...nel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28419 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ