linux-kernel - Re: [PATCH 09/21] x86/intel_rdt: Simplify info and base file lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1707061409300.3798@vshiva-Udesk>
Date:   Thu, 6 Jul 2017 14:09:40 -0700 (PDT)
From:   Shivappa Vikas <vikas.shivappa@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
cc:     Vikas Shivappa <vikas.shivappa@...ux.intel.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, hpa@...or.com, peterz@...radead.org,
        ravi.v.shankar@...el.com, vikas.shivappa@...el.com,
        tony.luck@...el.com, fenghua.yu@...el.com, andi.kleen@...el.com
Subject: Re: [PATCH 09/21] x86/intel_rdt: Simplify info and base file lists



On Sun, 2 Jul 2017, Thomas Gleixner wrote:

> On Mon, 26 Jun 2017, Vikas Shivappa wrote:
>> @@ -82,6 +82,7 @@ struct rdt_resource rdt_resources_all[] = {
>>  		},
>>  		.parse_ctrlval		= parse_cbm,
>>  		.format_str		= "%d=%0*x",
>> +		.fflags			= RFTYPE_RES_CACHE,
>>  	},
>
> Can you please convert that array to use explicit array member
> initializers? I've noticed this back when I reviewed the intial RDT
> implementation, but it somehow escaped. i.e.:
>
>      [RESOURCE_ID] =
>      {
> 	.....
>      }

Will fix.
Thanks,
Vikas

>
> Thanks,
>
> 	tglx
>
>