linux-kernel - Re: [PATCH 16/21] x86/intel_rdt/cqm: Add mount,umount support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1707061458080.3798@vshiva-Udesk>
Date:   Thu, 6 Jul 2017 14:58:29 -0700 (PDT)
From:   Shivappa Vikas <vikas.shivappa@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
cc:     Vikas Shivappa <vikas.shivappa@...ux.intel.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, hpa@...or.com, peterz@...radead.org,
        ravi.v.shankar@...el.com, vikas.shivappa@...el.com,
        tony.luck@...el.com, fenghua.yu@...el.com, andi.kleen@...el.com
Subject: Re: [PATCH 16/21] x86/intel_rdt/cqm: Add mount,umount support



On Sun, 2 Jul 2017, Thomas Gleixner wrote:

> On Mon, 26 Jun 2017, Vikas Shivappa wrote:
>>
>>  	list_for_each_entry_safe(rdtgrp, tmp, &rdt_all_groups, rdtgroup_list) {
>> +		/* Free any child rmids */
>> +		llist = &rdtgrp->crdtgrp_list;
>> +		list_for_each_entry_safe(sentry, stmp, llist, crdtgrp_list) {
>> +			free_rmid(sentry->rmid);
>> +			list_del(&sentry->crdtgrp_list);
>> +			kfree(sentry);
>> +		}
>
> I'm pretty sure, that I've seen exactly this code sequence already. Please
> create a helper instead of copying stuff over and over.

Thats right, during rmdir_ctrl_mon which deletes all its child mon groups. Will 
fix.

Thanks,
Vikas
>
> Thanks,
>
> 	tglx
>