linux-kernel - Re: [PATCH] NVMe: Added another device ID with stripe quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170706223955.GA1200@localhost.localdomain>
Date:   Thu, 6 Jul 2017 18:39:56 -0400
From:   Keith Busch <keith.busch@...el.com>
To:     Christoph Hellwig <hch@....de>
Cc:     David Wayne Fugate <david.fugate@...el.com>,
        Jens Axboe <axboe@...com>, Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NVMe: Added another device ID with stripe quirk

On Fri, Jul 07, 2017 at 12:17:54AM +0200, Christoph Hellwig wrote:
> On Thu, Jul 06, 2017 at 04:12:31PM -0600, David Wayne Fugate wrote:
> > Adds a fourth Intel controller which has the "stripe" quirk.
> 
> NVMe has stadardized a way to communicate this information through
> the Namespace Optimal IO Boundary (NOIOB) field in the Identify
> Namespace structure, and Keith and Amber at Intel helped to define
> this, so please actually implement it in your controllers.

That's true for all Intel controllers going forward, but this
is actually an older controller that pre-dates NOIOB. It's the exact
same as the 8086:0A54 model, but a particular vendor decided their
rebranded device needs to be made special with a different DID.

We all agree that's a terrible way to go about this for mutliple reasons,
but we can't go back in time to tell the decision makers of this folly. So
I think we need to let this last one go through with the quirk.

Acked-by: Keith Busch <keith.busch@...el.com>