linux-kernel - Re: [PATCH v3 4/5] selftests: ftrace: Output only to console with "--logdir -"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170707094255.5d14981b1a48218bebbe55a8@kernel.org>
Date:   Fri, 7 Jul 2017 09:42:55 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kselftest@...r.kernel.org, shuah@...nel.org,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        naresh.kamboju@...aro.org, Stafford Horne <shorne@...il.com>
Subject: Re: [PATCH v3 4/5] selftests: ftrace: Output only to console with
 "--logdir -"

On Thu, 6 Jul 2017 09:50:26 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu,  6 Jul 2017 18:10:58 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > @@ -255,12 +262,18 @@ __run_test() { # testfile
> >  # Run one test case
> >  run_test() { # testfile
> >    local testname=`basename $1`
> > -  local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > +  if [ ! -z "$LOG_FILE" ] ; then
> > +    local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > +  else
> > +    local testlog=`/proc/self/fd/1`
> 
> As Stafford mentioned. I don't think you want backticks here.

Oops, right!

-- 
Masami Hiramatsu <mhiramat@...nel.org>