linux-kernel - Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events (total and local)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jul 2017 08:47:36 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Shivappa Vikas <vikas.shivappa@...el.com>
cc:     Vikas Shivappa <vikas.shivappa@...ux.intel.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org, hpa@...or.com, peterz@...radead.org,
        ravi.v.shankar@...el.com, tony.luck@...el.com,
        fenghua.yu@...el.com, andi.kleen@...el.com
Subject: Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events
 (total and local)

On Thu, 6 Jul 2017, Shivappa Vikas wrote:
> On Sun, 2 Jul 2017, Thomas Gleixner wrote:
> > >  	INIT_LIST_HEAD(&r->evt_list);
> > > 
> > >  	if (rdt_mon_features & (1 << QOS_L3_OCCUP_EVENT_ID))
> > >  		list_add_tail(&llc_occupancy_event.list, &r->evt_list);
> > > +	if (is_mbm_total_enabled())
> > > +		list_add_tail(&mbm_total_event.list, &r->evt_list);
> > > +	if (is_mbm_local_enabled())
> > > +		list_add_tail(&mbm_local_event.list, &r->evt_list);
> > 
> > Confused. This hooks all monitoring features to RDT_RESOURCE_L3. Why?
> 
> They are really L3 resource events as per the spec.
> CPUID.(EAX=0FH, ECX=0):EDX.L3[bit 1] = 1 if L3 monitoring and we query for all
> the llc_occupancy, l3 total and local b/w with the same resource id 1.

Then this should be documented somewhere in the code ....