[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 07 Jul 2017 15:16:40 +0200
From: "Rafael J. Wysocki" <rjw@...ysocki.net>
To: "Lee, Chun-Yi" <joeyli.kernel@...il.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
"Lee, Chun-Yi" <jlee@...e.com>, Len Brown <lenb@...nel.org>,
Michal Hocko <mhocko@...e.cz>
Subject: Re: [PATCH v3] acpi: handle the acpi hotplug schedule error
On Friday, July 07, 2017 02:22:42 PM Lee, Chun-Yi wrote:
> Kernel should decrements the reference count of acpi device
> when the scheduling of acpi hotplug work failed, and evaluates
> _OST to notify BIOS the failure.
>
> v3:
> More simplify the code. (Rafael J. Wysocki)
>
> v2:
> To simplify the code. (Andy Shevchenko)
>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Len Brown <lenb@...nel.org>
> Cc: Michal Hocko <mhocko@...e.cz>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: "Lee, Chun-Yi" <jlee@...e.com>
This has been applied too AFAICS.
> ---
> drivers/acpi/bus.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 784bda6..9d4fea6 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -432,11 +432,15 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
> (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
> driver->ops.notify(adev, type);
>
> - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> + if (!hotplug_event) {
> + acpi_bus_put_acpi_device(adev);
> + return;
> + }
> +
> + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> return;
>
> acpi_bus_put_acpi_device(adev);
> - return;
>
> err:
> acpi_evaluate_ost(handle, type, ost_code, NULL);
>
Powered by blists - more mailing lists