linux-kernel - Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank time precision to ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7afd9048-ef07-1f72-72f3-d1d69d368f92@daenzer.net>
Date:   Fri, 7 Jul 2017 11:05:21 +0900
From:   Michel Dänzer <michel@...nzer.net>
To:     Keith Packard <keithp@...thp.com>,
        Dave Airlie <airlied@...hat.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 1/3] drm: Widen vblank count to 64 bits. Change vblank
 time precision to ns

On 07/07/17 10:34 AM, Michel Dänzer wrote:
> On 07/07/17 12:04 AM, Keith Packard wrote:
>> Michel Dänzer <michel@...nzer.net> writes:
>>
>>>> @@ -317,6 +317,9 @@ int via_driver_irq_postinstall(struct drm_device *dev)
>>>>  	if (!dev_priv)
>>>>  		return -EINVAL;
>>>>  
>>>> +	if (dev->driver->get_vblank_counter)
>>>> +		dev->max_vblank_count = 0xffffffff;
>>>
>>> What's the purpose of this? All drivers providing get_vblank_counter
>>> should already initialize max_vblank_count correctly.
>>
>> Yeah, I couldn't prove that this driver did that,
> 
> Which driver?
> 
>> and as Daniel says, we haven't ever audited the drivers to make sure
>> they do.
> 
> I don't think that's what he meant, rather that with the change above,
> all drivers have to be audited to make sure the added assignment doesn't
> clobber an earlier assignment by the driver.

... and if there are any drivers that set
dev->driver->get_vblank_counter but don't set dev->max_vblank_count to a
non-0 value, that the hardware counter actually has 32 bits.


I'd say don't bother, just drop this hunk.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer



Download attachment "signature.asc" of type "application/pgp-signature" (225 bytes)