linux-kernel - Re: [PATCH] extcon: int3496: constify acpi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 07 Jul 2017 13:13:09 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, myungjoo.ham@...sung.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: int3496: constify acpi_device_id.

On 2017년 07월 07일 01:55, Arvind Yadav wrote:
> acpi_device_id are not supposed to change at runtime. All functions
> working with acpi_device_id provided by <acpi/acpi_bus.h> work with
> const acpi_device_id. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    1733	    352	      0	   2085	    825 drivers/extcon/extcon-intel-int3496.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    1797	    272	      0	   2069	    815 drivers/extcon/extcon-intel-int3496.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/extcon/extcon-intel-int3496.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index 9d17984..49bf9c6 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -174,7 +174,7 @@ static int int3496_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct acpi_device_id int3496_acpi_match[] = {
> +static const struct acpi_device_id int3496_acpi_match[] = {
>  	{ "INT3496" },
>  	{ }
>  };
> 

Applied it.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics