lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Jul 2017 15:42:46 +0200 From: Martin Blumenstingl <martin.blumenstingl@...glemail.com> To: "Gustavo A. R. Silva" <garsilva@...eddedor.com> Cc: Jonathan Cameron <jic23@...nel.org>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, Carlo Caione <carlo@...one.org>, Kevin Hilman <khilman@...libre.com>, linux-iio@...r.kernel.org, linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] iio: adc: meson-saradc: add NULL check on of_match_device() return value On Fri, Jul 7, 2017 at 8:46 AM, Gustavo A. R. Silva <garsilva@...eddedor.com> wrote: > Check return value from call to of_match_device() > in order to prevent a NULL pointer dereference. > > In case of NULL print error message and return -ENODEV > > Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com> thanks for finding this. a crash here is a rather theoretical problem (since all compatible strings have their corresponding match data) - but it doesn't hurt either, so: Acked-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com> > --- > drivers/iio/adc/meson_saradc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index 83da50e..07dbcc3 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -915,6 +915,11 @@ static int meson_sar_adc_probe(struct platform_device *pdev) > init_completion(&priv->done); > > match = of_match_device(meson_sar_adc_of_match, &pdev->dev); > + if (!match) { > + dev_err(&pdev->dev, "failed to match device\n"); > + return -ENODEV; > + } > + > priv->data = match->data; > > indio_dev->name = priv->data->name; > -- > 2.5.0 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic
Powered by blists - more mailing lists