linux-kernel - Re: commit 67d7ddded32 (waitid(2): leave copyout of siginfo to syscall itself) breaks glibc posix/tst-waitid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170708135316.GA277@x4>
Date:   Sat, 8 Jul 2017 15:53:16 +0200
From:   Markus Trippelsdorf <markus@...ppelsdorf.de>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: commit 67d7ddded32 (waitid(2): leave copyout of siginfo to
 syscall itself) breaks glibc posix/tst-waitid

On 2017.07.08 at 14:12 +0100, Al Viro wrote:
> On Sat, Jul 08, 2017 at 11:56:44AM +0200, Markus Trippelsdorf wrote:
> > Since:
> >  commit 67d7ddded322db99f451a7959d56ed6c70a6c4aa
> >  Author: Al Viro <viro@...iv.linux.org.uk>
> >  Date:   Sun May 14 20:53:13 2017 -0400
> > 
> >      waitid(2): leave copyout of siginfo to syscall itself
> > 
> > the glibc posix/tst-waitid.c testcase fails:
> > 
> > markus@x4 glibc-build % ./posix/tst-waitid
> > waitid WNOHANG on stopped status 0
> 
> I think I see what's going on...  We lose the distinction between "got
> a PID" and "nothing, but that's not an error" a bit too early waitid()
> case.  Could you see if there are any problems left with the following
> applied?

No, everything looks nice now. Thanks.

-- 
Markus