linux-kernel - Re: [PATCH v1 1/1] mux: mux-core: Unregister mux_class in mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <996ec9aa-08d3-b9bb-9488-cf6fa15ffe35@axentia.se>
Date:   Sat, 8 Jul 2017 22:57:40 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     sathyanarayanan.kuppuswamy@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, sathyaosid@...il.com
Subject: Re: [PATCH v1 1/1] mux: mux-core: Unregister mux_class in mux_exit()

On 2017-07-07 23:50, sathyanarayanan.kuppuswamy@...ux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> 
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

Good catch!

However, I do not like the empty commit message, please add a sentence
about how this fixes a typo or something, and also please add this tag:

Fixes: a3b02a9c6591 ("mux: minimal mux subsystem")

Cheers,
peda

> ---
>  drivers/mux/mux-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c
> index 90b8995..2fe96c4 100644
> --- a/drivers/mux/mux-core.c
> +++ b/drivers/mux/mux-core.c
> @@ -46,7 +46,7 @@ static int __init mux_init(void)
>  
>  static void __exit mux_exit(void)
>  {
> -	class_register(&mux_class);
> +	class_unregister(&mux_class);
>  	ida_destroy(&mux_ida);
>  }
>  
>