linux-kernel - Re: [PATCH] staging: atomisp: gc0310: constify acpi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170708223413.35eg55wkhnqcmxzy@valkosipuli.retiisi.org.uk>
Date:   Sun, 9 Jul 2017 01:34:13 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Alan Cox <alan@...ux.intel.com>
Cc:     Arvind Yadav <arvind.yadav.cs@...il.com>, mchehab@...nel.org,
        gregkh@...uxfoundation.org, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: atomisp: gc0310: constify acpi_device_id.

On Fri, Jul 07, 2017 at 11:47:43AM +0100, Alan Cox wrote:
> On Thu, 2017-07-06 at 21:50 +0530, Arvind Yadav wrote:
> > acpi_device_id are not supposed to change at runtime. All functions
> > working with acpi_device_id provided by <acpi/acpi_bus.h> work with
> > const acpi_device_id. So mark the non-const structs as const.
> > 
> > File size before:
> >    text	   data	    bss	    dec	    hex	
> > filename
> >   10297	   1888	      0	  12185	   2f99
> > drivers/staging/media/atomisp/i2c/gc0310.o
> > 
> > File size After adding 'const':
> >    text	   data	    bss	    dec	    hex	
> > filename
> >   10361	   1824	      0	  12185	   2f99
> > drivers/staging/media/atomisp/i2c/gc0310.o
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> > ---
> >  drivers/staging/media/atomisp/i2c/gc0310.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c
> > b/drivers/staging/media/atomisp/i2c/gc0310.c
> > index 1ec616a..c8162bb 100644
> > --- a/drivers/staging/media/atomisp/i2c/gc0310.c
> > +++ b/drivers/staging/media/atomisp/i2c/gc0310.c
> > @@ -1453,7 +1453,7 @@ static int gc0310_probe(struct i2c_client
> > *client,
> >  	return ret;
> >  }
> >  
> > -static struct acpi_device_id gc0310_acpi_match[] = {
> > +static const struct acpi_device_id gc0310_acpi_match[] = {
> >  	{"XXGC0310"},
> >  	{},
> >  };
> 
> (All four)
> 
> Acked-by: Alan Cox <alan@...ux.intel.com>

There's four more... I've applied all to my atomisp branch.

Arvind: please send the patches as a single set next time.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk