linux-kernel - Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+5yK5FA3hLctjv-ysEspMveg+_M+JqvsM+UuEj88NTwX=4Sjg@mail.gmail.com>
Date:   Sat, 8 Jul 2017 18:55:48 -0400
From:   Amitoj Kaur Chawla <amitoj1606@...il.com>
To:     Bernd Petrovitsch <bernd@...rovitsch.priv.at>
Cc:     mchehab@...nel.org, Greg KH <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree()
 with kvfree()

On Sat, Jul 8, 2017 at 4:58 AM, Bernd Petrovitsch
<bernd@...rovitsch.priv.at> wrote:
> On Fri, 2017-07-07 at 20:41 -0400, Amitoj Kaur Chawla wrote:
> [...]
>> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
>> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
>> @@ -117,11 +117,7 @@ void *atomisp_kernel_zalloc(size_t bytes, bool
>> zero_mem)
>>   */
>>  void atomisp_kernel_free(void *ptr)
>>  {
>> -     /* Verify if buffer was allocated by vmalloc() or kmalloc()
>> */
>> -     if (is_vmalloc_addr(ptr))
>> -             vfree(ptr);
>> -     else
>> -             kfree(ptr);
>> +     kvfree(ptr);
>>  }
>>
>>  /*
>
> Why not get rid of the trivial wrapper function completely?
>

Oh yes, i'll send a v2.

Amitoj