linux-kernel - Re: [PATCH] printk: Modify operators of printed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOVJa8GyN6WKDqKvFqrNSjOqYoYD+bexy+i4LTV-534VQzAGYg@mail.gmail.com>
Date:   Sat, 8 Jul 2017 10:49:36 +0800
From:   pierre kuo <vichy.kuo@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     pmladek@...e.com,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        rostedt@...dmis.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: Modify operators of printed_len

hi Joe
>> > []
>> > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
>> >
>> > []
>> > > @@ -1754,7 +1754,7 @@ asmlinkage int vprintk_emit(int facility, int level,
>> > >       if (dict)
>> > >               lflags |= LOG_PREFIX|LOG_NEWLINE;
>> > >
>> > > -     printed_len += log_output(facility, level, lflags, dict, dictlen, text, text_len);
>> > > +     printed_len = log_output(facility, level, lflags, dict, dictlen, text, text_len);
>> >
>> > If this is appropriate, this should also remove the
>> > initialization of printed_len and perhaps rename it too.
>>
>> I cannot quite understand the reason why need to rename.
>> printed_len seems meet the meaning we expect for here.
>
> Verbosity.  To me, len would be adequate.
>
> Anyway, the real point was the declaration of printed_len could
> remove the " = 0" as it's now only set once.
Got it and I will resend the patch again.

Appreciate your kind advice.