linux-kernel - Re: [PATCH 1/3] net: stmmac: Fix error handling path in 'alloc_dma_rx_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fce9a8f9-437b-2c14-a733-d8ec956f66c8@st.com>
Date:   Mon, 10 Jul 2017 08:21:50 +0200
From:   Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <alexandre.torgue@...com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 1/3] net: stmmac: Fix error handling path in
 'alloc_dma_rx_desc_resources()'

On 7/8/2017 9:46 AM, Christophe JAILLET wrote:
> If the first 'kmalloc_array' within the loop fails, we should free what
> as already been allocated, as done in all other error handling path.
>
> Fixes: 54139cf3bb33 ("net: stmmac: adding multiple buffers for rx")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 19bba6281dab..4322fa4a13e8 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1498,7 +1498,7 @@ static int alloc_dma_rx_desc_resources(struct stmmac_priv *priv)
>   						    sizeof(dma_addr_t),
>   						    GFP_KERNEL);
>   		if (!rx_q->rx_skbuff_dma)
> -			return -ENOMEM;
> +			goto err_dma;
>   
>   		rx_q->rx_skbuff = kmalloc_array(DMA_RX_SIZE,
>   						sizeof(struct sk_buff *),