linux-kernel - Re: [PATCH] kernel: cpu: hotplug: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170710071442.pvfbfknsn5hmjqk4@linutronix.de>
Date:   Mon, 10 Jul 2017 09:14:42 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tglx@...utronix.de, mingo@...nel.org, anna-maria@...utronix.de,
        boris.ostrovsky@...cle.com, rcochran@...utronix.de,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: cpu: hotplug: constify attribute_group
 structures.

On 2017-06-29 17:40:47 [+0530], Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   12582	  15361	     20	  27963	   6d3b	kernel/cpu.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   12710	  15265	     20	  27995	   6d5b	kernel/cpu.o

While there does not seem to be anything wrong with it, why did the file
grow after the patch was applied?

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Sebastian