lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Jul 2017 10:24:25 +0000 From: Ilan Tayari <ilant@...lanox.com> To: Arnd Bergmann <arnd@...db.de>, Saeed Mahameed <saeedm@...lanox.com> CC: Matan Barak <matanb@...lanox.com>, Leon Romanovsky <leonro@...lanox.com>, Yossi Kuperman <yossiku@...lanox.com>, Yevgeny Kliteynik <kliteyn@...lanox.com>, Boris Pismenny <borisp@...lanox.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@...db.de] > Subject: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly > > The new IPSec offload code introduced a build error: > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.o: In function > `mlx5e_ipsec_build_inverse_table': > ipsec_rxtx.c:(.text+0x556): undefined reference > > Another patch was added on top to fix the build error, but > that introduced a new bug, as we now use the remainder of > the division rather than the result. > > This makes it use the correct helper function instead. > > Fixes: 5dfd87b67cd9 ("net/mlx5: IPSec, Fix 64-bit division on 32-bit > builds") > Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data > path") > Signed-off-by: Arnd Bergmann <arnd@...db.de> This is a good fix. Values are now generated correctly. Sorry for the mixup. Thank you Arnd! Reviewed-by: Ilan Tayari <ilant@...lanox.com>
Powered by blists - more mailing lists