linux-kernel - [PATCH] 9p: hide cachetag option for non-CONFIG_9P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170710112154.940606-1-arnd@arndb.de>
Date:   Mon, 10 Jul 2017 13:21:41 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Eric Van Hensbergen <ericvh@...il.com>,
        Ron Minnich <rminnich@...dia.gov>,
        Latchesar Ionkov <lucho@...kov.net>,
        Ingo Molnar <mingo@...nel.org>, Jens Axboe <axboe@...com>,
        David Howells <dhowells@...hat.com>, Jan Kara <jack@...e.cz>,
        v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE

show_options cannot print this option when it is disabled in Kconfig:

fs/9p/v9fs.c: In function 'v9fs_show_options':
fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?

Fixes: ccb0055985b9 ("9p: Implement show_options")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 fs/9p/v9fs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index d69046650a36..8fb89ddc6cc7 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -137,8 +137,10 @@ int v9fs_show_options(struct seq_file *m, struct dentry *root)
 		seq_puts(m, ",nodevmap");
 	if (v9ses->cache)
 		seq_printf(m, ",%s", v9fs_cache_modes[v9ses->cache]);
+#ifdef CONFIG_9P_FSCACHE
 	if (v9ses->cachetag && v9ses->cache == CACHE_FSCACHE)
 		seq_printf(m, ",cachetag=%s", v9ses->cachetag);
+#endif
 
 	switch (v9ses->flags & V9FS_ACCESS_MASK) {
 	case V9FS_ACCESS_USER:
-- 
2.9.0