linux-kernel - Re: [PATCH] nvmem: include linux/err.h from header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3LaeA6Ycw_FryAUBOeJ3PCH36u6XLw8Bgf6+2o3TO52g@mail.gmail.com>
Date:   Mon, 10 Jul 2017 14:10:03 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmem: include linux/err.h from header

On Mon, Jul 10, 2017 at 1:33 PM, Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
>
>
> On 10/07/17 12:22, Arnd Bergmann wrote:
>>
>> The new support for nvmem devices from the rtc layer caused a build
>> error in some configurations:
>>
>> include/linux/nvmem-provider.h: In function 'nvmem_register':
>> include/linux/nvmem-provider.h:51:9: error: implicit declaration of
>> function 'ERR_PTR' [-Werror=implicit-function-declaration]
>>
>> This adds the missing include to ensure we can always include
>> the header.
>>
>> Fixes: 697e5a47aa12 ("rtc: add generic nvmem support")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>> I'd suggest adding this patch in the rtc tree on top of the
>> nvmem support there.
>
>
> Thanks for the patch, we would need similar patch for
> include/linux/nvmem-consumer.h too.

Makes sense, yes. Can you do that for 4.14? My patch for now is
needed to fix a build regression in the rtc-next tree that I
assume will otherwise make it into the 4.13 release.

> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

Thanks!

    Arnd