linux-kernel - Re: [PATCH] libceph: fix old style declaration warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2017 15:17:55 +0200
From:   Ilya Dryomov <idryomov@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>,
        Ceph Development <ceph-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libceph: fix old style declaration warnings

On Mon, Jul 10, 2017 at 1:17 PM, Arnd Bergmann <arnd@...db.de> wrote:
> The new macros don't follow the usual style for declarations,
> which we get a warning for with 'make W=1':
>
> In file included from fs/ceph/mds_client.c:16:0:
> include/linux/ceph/ceph_features.h:74:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
>
> This moves the 'static' keyword to the front of the
> declaration.
>
> Fixes: f179d3ba8cb9 ("libceph: new features macros")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.

Thanks,

                Ilya