linux-kernel - Re: [PATCH] Staging:ks7010:ks_wlan_net.c: unneeded type casting removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1499693983.5468.6.camel@perches.com>
Date:   Mon, 10 Jul 2017 06:39:43 -0700
From:   Joe Perches <joe@...ches.com>
To:     AndyS <lkd1024@...l.ru>, gregkh@...uxfoundation.org
Cc:     me@...in.cc, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, shiva@...ev.nl
Subject: Re: [PATCH] Staging:ks7010:ks_wlan_net.c: unneeded type casting
 removed

On Mon, 2017-07-10 at 10:09 +0300, AndyS wrote:
> removed undesired type casting. Warning was raised by checkpatch.pl
> This patch is for eudyptula challenge

False positive in checkpatch.
checkpatch does not handle floating point values.

> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
[]
> @@ -208,7 +208,7 @@ static int ks_wlan_set_freq(struct net_device *dev,
>  	/* for SLEEP MODE */
>  	/* If setting by frequency, convert to a channel */
>  	if ((fwrq->e == 1) &&
> -	    (fwrq->m >= (int)2.412e8) && (fwrq->m <= (int)2.487e8)) {
> +	    (fwrq->m >= 2.412e8) && (fwrq->m <= 2.487e8)) {
>  		int f = fwrq->m / 100000;
>  		int c = 0;
>