linux-kernel - Re: [PATCH] char/mwave: make some arrays static const to make object code smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0dc756ce-1daa-f226-12ec-6e596d2ed23f@canonical.com>
Date:   Mon, 10 Jul 2017 16:32:26 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] char/mwave: make some arrays static const to make object
 code smaller

On 10/07/17 16:28, Arnd Bergmann wrote:
> On Mon, Jul 10, 2017 at 5:08 PM, Colin King <colin.king@...onical.com> wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Don't populate arrays on the stack but make them static.  Makes
>> the object code smaller.  Also remove temporary variables that
>> have hard coded array sizes and just use ARRAY_SIZE instead and
>> wrap some lines that are wider than 80 chars to clean up some
>> checkpatch warnings.
>>
>> Before:
>>    text    data     bss     dec     hex filename
>>   11141    2008      64   13213    339d drivers/char/mwave/smapi.o
>>
>> After:
>>    text    data     bss     dec     hex filename
>>   10697    2352      64   13113    3339 drivers/char/mwave/smapi.o
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> Did you use a particular tool that found these variables?

I'm using some grep foo and some targeted eyeballing.

> 
> I assume you are not actually using the driver ;-)
>