linux-kernel - Re: [PATCH] binfmt_flat: fix format string for u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1499701743.5468.13.camel@perches.com>
Date:   Mon, 10 Jul 2017 08:49:03 -0700
From:   Joe Perches <joe@...ches.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     Greg Ungerer <gerg@...ux-m68k.org>,
        Nicolas Pitre <nicolas.pitre@...aro.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binfmt_flat: fix format string for u32

On Mon, 2017-07-10 at 13:08 +0200, Arnd Bergmann wrote:
> The types have changed from 'unsigned long' to 'u32', so now the
> format string is wrong, and produces a harmless warning on arm32:
[]
> This changes it to '%d' instead, matching the 'u32' type.
[]
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
[]
> @@ -574,7 +574,7 @@ static int load_flat_file(struct linux_binprm *bprm,
>  				MAX_SHARED_LIBS * sizeof(unsigned long),
>  				FLAT_DATA_ALIGN);
>  
> -		pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n",
> +		pr_debug("Allocated data+bss+stack (%d bytes): %lx\n",
>  			 data_len + bss_len + stack_len, datapos);

Ideally, %u not %d as data_len, bss_len and stack_len are all u32