linux-kernel - Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170710183244.hds7lyoxoymiza7r@sirena.org.uk>
Date:   Mon, 10 Jul 2017 19:32:44 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Aravind Thokala <aravind.thk@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-spi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings

On Fri, Jun 30, 2017 at 11:08:15PM +0530, Aravind Thokala wrote:
> Hello Mark,

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> These warnings looked straightforward for me so I've fixed those and
> sent the patch.

> Kindly let me know if you want to record the warnings in the patch so
> that I could send v2 patch as soon as possible.

It's not just a case of quoting the warnings, it's a case of explaining
what your patch changes which usually requires more than just quoting
the warning.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)