linux-kernel - Re: [PATCH] iio:adc:at91-sama5d2: make array startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65b9dd81-6c80-be97-513a-c7b0bec1ffa1@canonical.com>
Date:   Mon, 10 Jul 2017 22:34:31 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio:adc:at91-sama5d2: make array startup_lookup static

On 10/07/17 21:59, Jonathan Cameron wrote:
> On Mon, 10 Jul 2017 17:56:16 +0100
> Colin King <colin.king@...onical.com> wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Don't populate array startup_lookup on the stack but instead make
>> it static.  Makes the object code smaller.  Also add in missing 'int' type
>> specifier to clean up a checkpatch warning.
>>
>> Before:
>>    text	   data	    bss	    dec	    hex	filename
>>   10297	   2800	    128	  13225	   33a9	drivers/iio/adc/at91-sama5d2_adc.o
>>
>> After:
>>    text	   data	    bss	    dec	    hex	filename
>>   10140	   2888	    128	  13156	   3364	drivers/iio/adc/at91-sama5d2_adc.o
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Hi Colin
> 
> I'm guessing accidental repost?  I applied this yesterday and you haven't marked
> it as a resend!

Yes, sorry, I lost track of what I was working on. Apologies.

> 
> Jonathan
>> ---
>>  drivers/iio/adc/at91-sama5d2_adc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
>> index e10dca3ed74b..509988a6817a 100644
>> --- a/drivers/iio/adc/at91-sama5d2_adc.c
>> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
>> @@ -231,7 +231,7 @@ static const struct iio_chan_spec at91_adc_channels[] = {
>>  static unsigned at91_adc_startup_time(unsigned startup_time_min,
>>  				      unsigned adc_clk_khz)
>>  {
>> -	const unsigned startup_lookup[] = {
>> +	static const unsigned int startup_lookup[] = {
>>  		  0,   8,  16,  24,
>>  		 64,  80,  96, 112,
>>  		512, 576, 640, 704,
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>