linux-kernel - Re: [greybus-dev] [PATCH v2] staging: greybus: arche: wrap over-length lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2017 10:16:32 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Mitchell Tasman <tasman@...flabs.com>
Cc:     Vaibhav Hiremath <hvaibhav.linux@...il.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, greybus-dev@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [greybus-dev] [PATCH v2] staging: greybus: arche: wrap
 over-length lines

Hi Mitchell,

On 09-07-17, 20:25, Mitchell Tasman wrote:
> Adjust formatting of various statements to keep line length within
> the 80 column limit preferred by the Linux kernel coding style.

We try to follow that most of the time, but the end result should be easily
readable.  If it isn't, then we just ignore the rule.

> Signed-off-by: Mitchell Tasman <tasman@...flabs.com>
> ---
> Changes in v2: Add back a missing space in a comment
> 
>  drivers/staging/greybus/arche-platform.c | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index eced2d2..eedd239 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -172,15 +172,21 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  		if (arche_pdata->wake_detect_state == WD_STATE_BOOT_INIT) {
>  			if (time_before(jiffies,
>  					arche_pdata->wake_detect_start +
> -					msecs_to_jiffies(WD_COLDBOOT_PULSE_WIDTH_MS))) {
> -				arche_platform_set_wake_detect_state(arche_pdata,
> -								     WD_STATE_IDLE);
> +					msecs_to_jiffies(
> +						WD_COLDBOOT_PULSE_WIDTH_MS))) {
> +				arche_platform_set_wake_detect_state(

We don't break the lines like this in kernel to satisfy the 80 column width
rule. Surely, some places would have similar code, but in general this isn't
recommended. And that's why we never bothered about 80 column rule in this and
below cases.

> +								arche_pdata,
> +								WD_STATE_IDLE);
>  			} else {
> -				/* Check we are not in middle of irq thread already */
> +				/*
> +				 * Check we are not in middle of irq thread
> +				 * already
> +				 */

Yes, such changes would be fine.

>  				if (arche_pdata->wake_detect_state !=
>  						WD_STATE_COLDBOOT_START) {
> -					arche_platform_set_wake_detect_state(arche_pdata,
> -									     WD_STATE_COLDBOOT_TRIG);
> +					arche_platform_set_wake_detect_state(

Not this.

> +							arche_pdata,
> +							WD_STATE_COLDBOOT_TRIG);
>  					spin_unlock_irqrestore(
>  						&arche_pdata->wake_lock,
>  						flags);
> @@ -199,8 +205,9 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  			 * beyond 30msec, then it is coldboot else fallback
>  			 * to standby boot.
>  			 */
> -			arche_platform_set_wake_detect_state(arche_pdata,
> -							     WD_STATE_BOOT_INIT);
> +			arche_platform_set_wake_detect_state(

Not this.

> +							arche_pdata,
> +							WD_STATE_BOOT_INIT);
>  		}
>  	}
>  
> @@ -657,12 +664,14 @@ static SIMPLE_DEV_PM_OPS(arche_platform_pm_ops,
>  			arche_platform_resume);
>  
>  static const struct of_device_id arche_platform_of_match[] = {
> -	{ .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
> +	/* Use PID/VID of SVC device */
> +	{ .compatible = "google,arche-platform", },

This would be fine though.

>  	{ },
>  };
>  
>  static const struct of_device_id arche_combined_id[] = {
> -	{ .compatible = "google,arche-platform", }, /* Use PID/VID of SVC device */
> +	/* Use PID/VID of SVC device */
> +	{ .compatible = "google,arche-platform", },
>  	{ .compatible = "usbffff,2", },
>  	{ },
>  };

-- 
viresh