linux-kernel - Re: [PATCH] dma: k3dma: Fix non-cyclic mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262406f1-b6e3-fb63-b85b-bc341e0d4b6a@linaro.org>
Date:   Tue, 11 Jul 2017 09:16:32 +0800
From:   zhangfei <zhangfei.gao@...aro.org>
To:     John Stultz <john.stultz@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>
Cc:     Antonio Borneo <borneo.antonio@...il.com>,
        Vinod Koul <vinod.koul@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH] dma: k3dma: Fix non-cyclic mode



On 2017年07月11日 04:53, John Stultz wrote:
> From: Antonio Borneo <borneo.antonio@...il.com>
>
> Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma: Fix
> memory handling in preparation for cyclic mode") broke the
> logic around ds_run/ds_done in case of non-cyclic DMA.
>
> This went unnoticed as the only user of k3dma was the i2s
> audio driver, but with a patch set to enable dma on SPI,
> the issue cropped up.
>
> This patch resolves the issue by reverting part of the
> problematic commit.
>
> This patch has been tested to ensure both audio playback and SPI
> works fine using DMA and that no memory leak is present.
>
> Cc: Vinod Koul <vinod.koul@...el.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Zhangfei Gao <zhangfei.gao@...aro.org>
> Cc: dmaengine@...r.kernel.org
> Signed-off-by: Antonio Borneo <borneo.antonio@...il.com>
> [jstultz: Expanded commit message a bit]
> Signed-off-by: John Stultz <john.stultz@...aro.org>

Acked-by: Zhangfei Gao <zhangfei.gao@...aro.org>

Thanks