linux-kernel - Re: [PATCH 3/3] ARM: dts: at91: sama5d2: use sama5d2 compatible string for SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170711075829.5rzdrjgao6efiuj2@rfolt0960.corp.atmel.com>
Date:   Tue, 11 Jul 2017 09:58:29 +0200
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Nicolas Ferre <nicolas.ferre@...rochip.com>
CC:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <lee.jones@...aro.org>, <alexandre.belloni@...e-electrons.com>,
        <boris.brezillon@...e-electrons.com>, <computersforpeace@...il.com>
Subject: Re: [PATCH 3/3] ARM: dts: at91: sama5d2: use sama5d2 compatible
 string for SMC

On Tue, Jul 11, 2017 at 09:52:58AM +0200, Nicolas Ferre wrote:
> On 11/07/2017 at 09:40, Ludovic Desroches wrote:
> > A new compatible string has been introduced for sama5d2 SMC to allow to
> > manage the registers mapping change.
> > 
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
> > ---
> >  arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> > index 4fcd5bb219e3..60e69aeacbdb 100644
> > --- a/arch/arm/boot/dts/sama5d2.dtsi
> > +++ b/arch/arm/boot/dts/sama5d2.dtsi
> > @@ -1048,7 +1048,7 @@
> >  			};
> >  
> >  			hsmc: hsmc@...14000 {
> > -				compatible = "atmel,sama5d3-smc", "syscon", "simple-mfd";
> > +				compatible = "atmel,sama5d2-smc", "syscon", "simple-mfd";
> 
> You'd better use something like:
>  compatible = "atmel,sama5d2-smc", "atmel,sama5d3-smc", "syscon", "simple-mfd";

But it's not true, during data interface setup, we will write values in
the wrong place if we fallback on "atmel,sama5d3-smc".

Regards

Ludovic

> 
> So that this patch is independent from the rest of the series and
> we can avoid to having to synchronize with mfd or mtd/nand for this part.
> 
> Regards,
> 
> >  				reg = <0xf8014000 0x1000>;
> >  				interrupts = <17 IRQ_TYPE_LEVEL_HIGH 6>;
> >  				clocks = <&hsmc_clk>;
> > 
> 
> 
> -- 
> Nicolas Ferre