linux-kernel - Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60de1301-b4a3-95a7-117f-a953576655d9@broadcom.com>
Date:   Tue, 11 Jul 2017 10:58:03 +0200
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Russell Joyce <russell.joyce@...k.ac.uk>,
        Rafał Miłecki <zajec5@...il.com>
Cc:     Alan Millard <alan.millard@...k.ac.uk>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Wright Feng <wright.feng@...ress.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Marcel Holtmann <marcel@...tmann.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>,
        Rafał Miłecki <rafal@...ecki.pl>,
        "mhiramat@...nel.org" <mhiramat@...nel.org>,
        James Hughes <james.hughes@...pberrypi.org>,
        Tobias Klauser <tklauser@...tanz.ch>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        brcm80211-dev-list@...ress.com,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

On 10-07-17 19:02, Russell Joyce wrote:
>> 1) I think most of it should be some cfg80211 shareable code.
> 
> I’m not sure exactly what you mean by this, could you please clarify?

What I think Rafał is saying is that it would be better to have this
code in cfg80211 so other drivers including mac80211 could use it.

>> 2) This "rxtx" while surely present in other places sounds like a
>> workaround for LED subsystem limitation. Maybe it's time to finally
>> rework LED triggers.
> 
> I agree that it’s not an ideal way to do things, but I couldn’t think of a
> better alternative. I think that having a combined trigger is useful though, for
> situations like using the single LED on a Raspberry Pi to show Wi-Fi activity.

Indeed. However, the LED subsystem could/should(?) take care of mapping
"rx" and "tx" triggers to the same LED.

I am happy to comment on your patch, but maybe you can first take a look
at the suggestion Rafał made above.

Regards,
Arend