linux-kernel - [tip:perf/urgent] Revert "perf/core: Drop kernel samples even though :u is specified"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-6a8a75f3235724c5941a33e287b2f98966ad14c5@git.kernel.org>
Date:   Tue, 11 Jul 2017 02:03:52 -0700
From:   tip-bot for Ingo Molnar <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     jolsa@...hat.com, mingo@...nel.org, namhyung@...nel.org,
        me@...ehuey.com, eranian@...gle.com, a.p.zijlstra@...llo.nl,
        alexander.shishkin@...ux.intel.com, will.deacon@....com,
        yao.jin@...ux.intel.com, linux-kernel@...r.kernel.org,
        hpa@...or.com, vincent.weaver@...ne.edu,
        torvalds@...ux-foundation.org, acme@...hat.com,
        stable@...r.kernel.org, tglx@...utronix.de
Subject: [tip:perf/urgent] Revert "perf/core: Drop kernel samples even
 though :u is specified"

Commit-ID:  6a8a75f3235724c5941a33e287b2f98966ad14c5
Gitweb:     http://git.kernel.org/tip/6a8a75f3235724c5941a33e287b2f98966ad14c5
Author:     Ingo Molnar <mingo@...nel.org>
AuthorDate: Tue, 11 Jul 2017 10:56:54 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 11 Jul 2017 10:56:54 +0200

Revert "perf/core: Drop kernel samples even though :u is specified"

This reverts commit cc1582c231ea041fbc68861dfaf957eaf902b829.

This commit introduced a regression that broke rr-project, which uses sampling
events to receive a signal on overflow (but does not care about the contents
of the sample). These signals are critical to the correct operation of rr.

There's been some back and forth about how to fix it - but to not keep
applications in limbo queue up a revert.

Reported-by: Kyle Huey <me@...ehuey.com>
Acked-by: Kyle Huey <me@...ehuey.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Jin Yao <yao.jin@...ux.intel.com>
Cc: Vince Weaver <vincent.weaver@...ne.edu>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Will Deacon <will.deacon@....com>
Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: Stephane Eranian <eranian@...gle.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Jiri Olsa <jolsa@...hat.com>
Cc: <stable@...r.kernel.org>
Link: http://lkml.kernel.org/r/20170628105600.GC5981@leverpostej
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/events/core.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 4d2c32f..9747e42 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7308,21 +7308,6 @@ int perf_event_account_interrupt(struct perf_event *event)
 	return __perf_event_account_interrupt(event, 1);
 }
 
-static bool sample_is_allowed(struct perf_event *event, struct pt_regs *regs)
-{
-	/*
-	 * Due to interrupt latency (AKA "skid"), we may enter the
-	 * kernel before taking an overflow, even if the PMU is only
-	 * counting user events.
-	 * To avoid leaking information to userspace, we must always
-	 * reject kernel samples when exclude_kernel is set.
-	 */
-	if (event->attr.exclude_kernel && !user_mode(regs))
-		return false;
-
-	return true;
-}
-
 /*
  * Generic event overflow handling, sampling.
  */
@@ -7344,12 +7329,6 @@ static int __perf_event_overflow(struct perf_event *event,
 	ret = __perf_event_account_interrupt(event, throttle);
 
 	/*
-	 * For security, drop the skid kernel samples if necessary.
-	 */
-	if (!sample_is_allowed(event, regs))
-		return ret;
-
-	/*
 	 * XXX event_limit might not quite work as expected on inherited
 	 * events
 	 */