[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170711114034.aamhq332wusj3irj@hirez.programming.kicks-ass.net>
Date: Tue, 11 Jul 2017 13:40:34 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Joel Fernandes <joelaf@...gle.com>
Cc: linux-kernel@...r.kernel.org, patrick.bellasi@....com,
juri.lelli@....com, andresoportus@...gle.com,
dietmar.eggemann@....com,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Len Brown <lenb@...nel.org>,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
Viresh Kumar <viresh.kumar@...aro.org>,
Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy
efficient
On Sun, Jul 09, 2017 at 10:08:26AM -0700, Joel Fernandes wrote:
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -53,7 +53,9 @@ struct sugov_cpu {
> struct update_util_data update_util;
> struct sugov_policy *sg_policy;
>
> + bool prev_iowait_boost;
> unsigned long iowait_boost;
So I absolutely detest 'bool' in composite types, but I see there's
already some of that in this file :/
Powered by blists - more mailing lists