linux-kernel - Re: [PATCH] staging: bcm2835-audio: remove more than 80 char error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1499775192.4457.10.camel@perches.com>
Date:   Tue, 11 Jul 2017 05:13:12 -0700
From:   Joe Perches <joe@...ches.com>
To:     Karuna Grewal <karunagrewal98@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: bcm2835-audio: remove more than 80 char error

On Tue, 2017-07-11 at 16:59 +0530, Karuna Grewal wrote:
>     remove the more than 80 character error as pointed out by checkpatch by
>     spliting the statements at the separators in the statements .

Not every 80 column warning needs fixing.

Your selection of separators is poor.  For instance:

> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
[]
> @@ -116,14 +116,19 @@ static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
>  		return -EINTR;
>  
>  	if (kcontrol->private_value == PCM_PLAYBACK_VOLUME) {
> -		audio_info("Volume change attempted.. volume = %d new_volume = %d\n", chip->volume, (int)ucontrol->value.integer.value[0]);
> +		audio_info(
> +			"Volume change attempted.. volume = %d new_volume = %d\n",
> +	chip->volume, (int)ucontrol->value.integer.value[0]);

Better:

		audio_info("Volume change attempted.. volume = %d new_volume = %d\n",
			   chip->volume, (int)ucontrol->value.integer.value[0]);

[]

> -		if (changed || (ucontrol->value.integer.value[0] != chip2alsa(chip->volume))) {
> -			chip->volume = alsa2chip(ucontrol->value.integer.value[0]);
> +		if (changed || (ucontrol->value.integer.value[0] != chip2alsa(
> +			chip->volume))) {
> +			chip->volume =
> +			alsa2chip(ucontrol->value.integer.value[0]);

Better:
		if (changed ||
		    ucontrol->value.integer.value[0] != chip2alsa(chip->volume) {
			chip->volume = alsa2chip(ucontrol->value.integer.value[0]);
			changed = 1;
		}

etc...