linux-kernel - Re: [PATCH 1/2] staging: ccree: remove unnecessary cast on kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOtvUMd6LrRTddMfuGYg81K9EwX08SZeEYOta7ipUNAjSk2ZKg@mail.gmail.com>
Date:   Tue, 11 Jul 2017 16:44:42 +0300
From:   Gilad Ben-Yossef <gilad@...yossef.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging: ccree: remove unnecessary cast on kmalloc

On Sun, Jul 9, 2017 at 8:43 AM, Gustavo A. R. Silva
<garsilva@...eddedor.com> wrote:
> The assignment operator implicitly converts a void pointer to the type of the
> pointer it is assigned to.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @@
> expression * e;
> expression arg1, arg2;
> type T;
> @@
>
> - e=(T*)
> + e=
> kmalloc(arg1, arg2);
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

For both patches:

Acked-by: Gilad Ben-Yossef <gilad@...yossef.com>

> ---
>  drivers/staging/ccree/ssi_buffer_mgr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c
> index b35871e..18a8694 100644
> --- a/drivers/staging/ccree/ssi_buffer_mgr.c
> +++ b/drivers/staging/ccree/ssi_buffer_mgr.c
> @@ -1725,8 +1725,7 @@ int ssi_buffer_mgr_init(struct ssi_drvdata *drvdata)
>         struct buff_mgr_handle *buff_mgr_handle;
>         struct device *dev = &drvdata->plat_dev->dev;
>
> -       buff_mgr_handle = (struct buff_mgr_handle *)
> -               kmalloc(sizeof(struct buff_mgr_handle), GFP_KERNEL);
> +       buff_mgr_handle = kmalloc(sizeof(struct buff_mgr_handle), GFP_KERNEL);
>         if (!buff_mgr_handle)
>                 return -ENOMEM;
>
> --
> 2.5.0
>

Thanks,
Gilad



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru