linux-kernel - Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jul 2017 22:39:24 +0800
From:   Alex Shi <alex.shi@...aro.org>
To:     peterz@...radead.org, mingo@...hat.com, corbet@....net,
        "open list:LOCKING PRIMITIVES" <linux-kernel@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Juri Lelli <juri.lelli@....com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio

Any comments for this little change? It's passed on 0day testing.

Thanks
Alex

On 07/07/2017 10:52 AM, Alex Shi wrote:
> We don't need to adjust prio before new pi_waiter adding. The prio
> only need update after pi_waiter change or task priority change.
> 
> Signed-off-by: Alex Shi <alex.shi@...aro.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Sebastian Siewior <bigeasy@...utronix.de>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Cc: Juri Lelli <juri.lelli@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> To: linux-kernel@...r.kernel.org
> To: Ingo Molnar <mingo@...hat.com>
> To: Peter Zijlstra <peterz@...radead.org>
> ---
>  kernel/locking/rtmutex.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
> index 28cd09e..d1fe41f 100644
> --- a/kernel/locking/rtmutex.c
> +++ b/kernel/locking/rtmutex.c
> @@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
>  		return -EDEADLK;
>  
>  	raw_spin_lock(&task->pi_lock);
> -	rt_mutex_adjust_prio(task);
>  	waiter->task = task;
>  	waiter->lock = lock;
>  	waiter->prio = task->prio;
>