linux-kernel - Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2017 00:45:36 +1000
From:   Aleksa Sarai <asarai@...e.de>
To:     David Laight <David.Laight@...LAB.COM>,
        'Gleb Fotengauer-Malinovskiy' <glebfm@...linux.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
        Valentin Rothberg <vrothberg@...e.com>,
        "linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        "linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
        "linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Dmitry V. Levin" <ldv@...linux.org>, Jiri Slaby <jslaby@...e.com>,
        "sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
        Christian Brauner <christian.brauner@...ntu.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

>> Sent: 11 July 2017 01:12
>> This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag
>> because it doesn't copy anything from/to userspace to access the
>> argument.
>>
>> Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl")
> ...
>> -#define TIOCGPTPEER	_IOR('T', 0x41, int) /* Safely open the slave */
>> +#define TIOCGPTPEER	_IO('T', 0x41) /* Safely open the slave */
> 
> This is a user API change. When was the ioctl added?

It was just pulled this merge window (4.13-rc1).

  % git tag --contains 54ebbfb1603415d9953c150535850d30609ef077
  %

-- 
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/