linux-kernel - Re: [PATCH v3 2/7] libsas: remove unused port_gone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e76b392c-8fd7-9907-9a10-87b8c5b737dc@huawei.com>
Date:   Tue, 11 Jul 2017 16:54:59 +0100
From:   John Garry <john.garry@...wei.com>
To:     Yijing Wang <wangyijing@...wei.com>, <jejb@...ux.vnet.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <chenqilin2@...wei.com>, <hare@...e.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <chenxiang66@...ilicon.com>, <huangdaode@...ilicon.com>,
        <wangkefeng.wang@...wei.com>, <zhaohongjiang@...wei.com>,
        <dingtianhong@...wei.com>, <guohanjun@...wei.com>,
        <yanaijie@...wei.com>, <hch@....de>, <dan.j.williams@...el.com>,
        <emilne@...hat.com>, <thenzl@...hat.com>, <wefu@...hat.com>,
        <charles.chenxin@...wei.com>, <chenweilong@...wei.com>,
        Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion

On 10/07/2017 08:06, Yijing Wang wrote:
> No one uses the port_gone_completion in struct asd_sas_port,
> clean it out.

This seems like a reasonable tidy-up patch which could be taken in 
isolation, having no dependency on the rest of the series.

>
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> ---
>  include/scsi/libsas.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index c41328d..628f48b 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -263,8 +263,6 @@ struct sas_discovery {
>  /* The port struct is Class:RW, driver:RO */
>  struct asd_sas_port {
>  /* private: */
> -	struct completion port_gone_completion;
> -
>  	struct sas_discovery disc;
>  	struct domain_device *port_dev;
>  	spinlock_t dev_list_lock;
>