linux-kernel - Re: [PATCH 0/7] Constify platform/x86 attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170711162426.GE25390@fury>
Date:   Tue, 11 Jul 2017 09:24:26 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     andy@...radead.org, jwoithe@...t42.net,
        cezary.jackiewicz@...il.com, corentin.chary@...il.com,
        laforge@...monks.org, coproscefalo@...il.com,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] Constify platform/x86 attribute_group structures.

On Tue, Jul 11, 2017 at 04:18:13PM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.

Build tested, no warnings/errors found. Queued to testing, thanks Arvind.

> 
> Arvind Yadav (7):
>   [PATCH 1/7] platform/x86: fujitsu-laptop: constify attribute_group structures.
>   [PATCH 2/7] platform/x86: compal-laptop: constify attribute_group structures.
>   [PATCH 3/7] platform/x86: samsung-laptop: constify attribute_group structures.
>   [PATCH 4/7] platform/x86: alienware-wmi: constify attribute_group structures.
>   [PATCH 5/7] platform/x86: panasonic-laptop: constify attribute_group structures.
>   [PATCH 6/7] platform/x86: asus-wmi: constify attribute_group structures.
>   [PATCH 7/7] platform/x86: toshiba_acpi: constify attribute_group structures.
> 
>  drivers/platform/x86/alienware-wmi.c    | 6 +++---
>  drivers/platform/x86/asus-wmi.c         | 4 ++--
>  drivers/platform/x86/compal-laptop.c    | 2 +-
>  drivers/platform/x86/fujitsu-laptop.c   | 2 +-
>  drivers/platform/x86/panasonic-laptop.c | 2 +-
>  drivers/platform/x86/samsung-laptop.c   | 2 +-
>  drivers/platform/x86/toshiba_acpi.c     | 2 +-
>  7 files changed, 10 insertions(+), 10 deletions(-)
> 
> -- 
> 1.9.1
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center