[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170711180523.GA14938@kroah.com>
Date: Tue, 11 Jul 2017 20:05:23 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Joseph Wright <rjosephwright@...il.com>
Cc: arve@...roid.com, riandrews@...roid.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android/ion: fix sparse warnings
On Wed, Jul 05, 2017 at 12:12:24AM +0000, Joseph Wright wrote:
> ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
> was not declared. Should it be static?
> ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
> was not declared. Should it be static?
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> was not declared. Should it be static?
You are doing two different types of things here, please break this up
into multiple patches.
thanks,
greg k-h
Powered by blists - more mailing lists