linux-kernel - Re: [PATCH 3/3] PCI: hotplug: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <97d8f7b5-7939-6abb-4883-4582a16f374e@linux.vnet.ibm.com>
Date:   Tue, 11 Jul 2017 11:55:40 -0700
From:   Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, bhelgaas@...gle.com,
        paulus@...ba.org, mpe@...erman.id.au, benh@...nel.crashing.org
Cc:     linux-pci@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] PCI: hotplug: constify attribute_group structures.

On 07/11/2017 02:28 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>     418	    160	      8	    586	    24a	drivers/pci/hotplug/rpadlpar_sysfs.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>     482	     96	      8	    586	    232	drivers/pci/hotplug/rpadlpar_sysfs.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>