linux-kernel - Re: [PATCH 0/2] perf stat: fix segfault when closing events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFpQJXUeX9VCLiwdAYA9fu77Br=-jamk2=W956u1Cp+8PN1X3w@mail.gmail.com>
Date:   Wed, 12 Jul 2017 12:46:11 +0530
From:   Ganapatrao Kulkarni <gpkulkarni@...il.com>
To:     Mark Rutland <mark.rutland@....com>, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, Ingo Molnar <mingo@...hat.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ganapatrao.kulkarni@...ium.com" <ganapatrao.kulkarni@...ium.com>,
        Jayachandran C <jnair@...iumnetworks.com>,
        gpkulkarni <gpkulkarni@...il.com>
Subject: Re: [PATCH 0/2] perf stat: fix segfault when closing events

The perf tool segmentation fault which we were observing and this
patch series intended to fix it, has been fixed due to change in
default behaviour of perf stat[1][2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.12&id=0d79f8b93187c771b6971acfaba67f4e2f1e0710
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-4.11.y&id=0d79f8b93187c771b6971acfaba67f4e2f1e0710


On Fri, Jun 9, 2017 at 10:03 AM, Ganapatrao Kulkarni
<gpkulkarni@...il.com> wrote:
> ping?
>
> On Tue, May 23, 2017 at 8:44 PM, Ganapatrao Kulkarni
> <gpkulkarni@...il.com> wrote:
>> On Tue, May 23, 2017 at 3:34 PM, Mark Rutland <mark.rutland@....com> wrote:
>>> Hi,
>>>
>>> Does anyone have any comments on these?
>>>
>>> I'm happy to rebase/resend if necessary.
>>>
>>> I'd very much like to see this fixed.
>>
>> arm64 platforms have dependency on this patch set to use latest perf tool.
>> Earliest merge/review is much appreciated!!
>>
>>>
>>> Thanks,
>>> Mark.
>>>
>>> On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote:
>>>> Hi,
>>>>
>>>> These patches fix a segfault seen in some cases when perf stat is exiting.
>>>>
>>>> We don't balance opening/closing of events in all cases, and go out-of-bounds
>>>> when we close events. Full details in the patch 2 commit message.
>>>>
>>>> Thanks,
>>>> Mark.
>>>>
>>>> Mark Rutland (2):
>>>>   perf evsel: add per{cpu,thread} close helpers
>>>>   perf stat: balance opening/closing of events
>>>>
>>>>  tools/perf/builtin-stat.c | 24 +++++++++++++++++++++++-
>>>>  tools/perf/util/evsel.c   | 26 ++++++++++++++++++++------
>>>>  tools/perf/util/evsel.h   |  4 ++++
>>>>  3 files changed, 47 insertions(+), 7 deletions(-)
>>>>
>>>> --
>>>> 1.9.1
>>>>
>>
>> thanks
>> Ganapat

thanks
Ganapat