linux-kernel - Re: [PATCH 1/2] pinctrl: stm32: select IRQ_DOMAIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a12356e-14bf-9044-ddc7-ba3087843ee0@st.com>
Date:   Wed, 12 Jul 2017 10:09:01 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        <linux-gpio@...r.kernel.org>
CC:     Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-kernel@...r.kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] pinctrl: stm32: select IRQ_DOMAIN_HIERARCHY instead
 of depends on

Hi,

On 07/12/2017 01:11 AM, Masahiro Yamada wrote:
> Drivers that need IRQ_DOMAIN_HIERARCHY should "select" it, but
> drivers/pinctrl/stm32/Kconfig is the only exception that uses
> "depends on" syntax.  This prevents GPIO drivers from select'ing
> IRQ_DOMAIN_HIERARCHY.
> 
> For example, if I add "select IRQ_DOMAIN_HIERARCHY" to GPIO_XGENE_SB,
> I get the following recursive dependency error.
> 
> drivers/gpio/Kconfig:13:error: recursive dependency detected!
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/gpio/Kconfig:13:	symbol GPIOLIB is selected by PINCTRL_STM32
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/pinctrl/stm32/Kconfig:3:	symbol PINCTRL_STM32 is selected by PINCTRL_STM32F429
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/pinctrl/stm32/Kconfig:11:	symbol PINCTRL_STM32F429 depends on IRQ_DOMAIN_HIERARCHY
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> kernel/irq/Kconfig:67:	symbol IRQ_DOMAIN_HIERARCHY is selected by GPIO_XGENE_SB
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> drivers/gpio/Kconfig:502:	symbol GPIO_XGENE_SB depends on GPIOLIB
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com
> ---

Thanks for the patch.

Tested-by: Alexandre TORGUE <alexandre.torgue@...com>

regards
Alex


> 
>   drivers/pinctrl/stm32/Kconfig | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
> index 3b8026fca057..7e1fe39a56a5 100644
> --- a/drivers/pinctrl/stm32/Kconfig
> +++ b/drivers/pinctrl/stm32/Kconfig
> @@ -6,29 +6,30 @@ config PINCTRL_STM32
>   	select PINMUX
>   	select GENERIC_PINCONF
>   	select GPIOLIB
> +	select IRQ_DOMAIN_HIERARCHY
>   	select MFD_SYSCON
>   
>   config PINCTRL_STM32F429
>   	bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429
> -	depends on OF && IRQ_DOMAIN_HIERARCHY
> +	depends on OF
>   	default MACH_STM32F429
>   	select PINCTRL_STM32
>   
>   config PINCTRL_STM32F469
>   	bool "STMicroelectronics STM32F469 pin control" if COMPILE_TEST && !MACH_STM32F469
> -	depends on OF && IRQ_DOMAIN_HIERARCHY
> +	depends on OF
>   	default MACH_STM32F469
>   	select PINCTRL_STM32
>   
>   config PINCTRL_STM32F746
>   	bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746
> -	depends on OF && IRQ_DOMAIN_HIERARCHY
> +	depends on OF
>   	default MACH_STM32F746
>   	select PINCTRL_STM32
>   
>   config PINCTRL_STM32H743
>   	bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743
> -	depends on OF && IRQ_DOMAIN_HIERARCHY
> +	depends on OF
>   	default MACH_STM32H743
>   	select PINCTRL_STM32
>   endif
>