linux-kernel - Re: [PATCH] dt-bindings: clock: ti-sci: Fix incorrect usage of headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170712010923.GP22780@codeaurora.org>
Date:   Tue, 11 Jul 2017 18:09:23 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Suman Anna <s-anna@...com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Tero Kristo <t-kristo@...com>, Nishanth Menon <nm@...com>,
        Dave Gerlach <d-gerlach@...com>, devicetree@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: clock: ti-sci: Fix incorrect usage of
 headers

On 07/11, Suman Anna wrote:
> The clock consumer usage description was erroneously referring to
> couple of dt-binding headers that are no longer valid. The definition
> and/or usage of these headers is incorrect and the only file present
> at the moment, dt-bindings/soc/k2g.h is also being cleaned up. The
> examples in this binding were updated properly, but the update to
> description was missed out. So, fix this.
> 
> Fixes: 8f306cfe4383 ("Documentation: dt: Add TI SCI clock driver")
> Signed-off-by: Suman Anna <s-anna@...com>
> ---
> Hi Stephen,
> 
> Looks like this was missed during the update/repost of the ti-sci-clk
> driver/binding. FYI, Santosh is going to pickup the header file cleanup
> patch https://patchwork.kernel.org/patch/9741279/ for the next merge
> window.

I'll let Rob apply this as it is purely a binding document update.

> 
> regards
> Suman
> 
>  Documentation/devicetree/bindings/clock/ti,sci-clk.txt | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,sci-clk.txt b/Documentation/devicetree/bindings/clock/ti,sci-clk.txt
> index 1e884c40ab50..4e59dc6b1778 100644
> --- a/Documentation/devicetree/bindings/clock/ti,sci-clk.txt
> +++ b/Documentation/devicetree/bindings/clock/ti,sci-clk.txt
> @@ -14,10 +14,9 @@ Required properties:
>  - compatible: Must be "ti,k2g-sci-clk"
>  - #clock-cells: Shall be 2.
>    In clock consumers, this cell represents the device ID and clock ID
> -  exposed by the PM firmware. The assignments can be found in the header
> -  files <dt-bindings/genpd/<soc>.h> (which covers the device IDs) and
> -  <dt-bindings/clock/<soc>.h> (which covers the clock IDs), where <soc>
> -  is the SoC involved, for example 'k2g'.
> +  exposed by the PM firmware. The list of valid values for the device IDs
> +  and clocks IDs for 66AK2G SoC are documented at
> +  http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data
>  

I hope the weblink doesn't die in the future. Why can't we copy
it into the binding document here for safe keeping?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project