linux-kernel - Re: [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2017 09:34:19 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Martyn Welch <martyn.welch@...labora.co.uk>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Fabien Lahoudere <fabien.lahoudere@...labora.co.uk>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD

On Wed, Jul 12, 2017 at 9:32 AM, Fabio Estevam <festevam@...il.com> wrote:
> On Tue, Jul 11, 2017 at 10:42 AM, Martyn Welch
> <martyn.welch@...labora.co.uk> wrote:
>
>> Changes since PATCHv3: https://patchwork.kernel.org/patch/9819017/
>>  - licensing modified
>>  - manufacturer changed to GE
>>  - regulator nodes corrected
>>  - backlight node corrected
>>  - flags rather than magic numbers used
>>  - registers for usbphys added
>>  - set up IOMUX configuration correctly
>>  - various whitespace corrections
>>  - removed unused fsl,mode node
>
> Actually I still see 'fsl,mode' under the ssi2 node. Please remove it.
>
>> +#define I2C_PAD_CTL 0xc0000000
>
> This still sets bits 31, which means the kernel will rely on the IOMUX
> configuration from the bootloader.
>
> It is better if you could just pass the real IOMUX values here instead.

And please also fix the typo on the
linux-arm-kernel@...ts.infradead.org address next time :-)