linux-kernel - Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59656B6C.5020308@rock-chips.com>
Date:   Wed, 12 Jul 2017 08:21:00 +0800
From:   Mark yao <mark.yao@...k-chips.com>
To:     Heiko Stübner <heiko@...ech.de>
Cc:     David Airlie <airlied@...ux.ie>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of
 vop

On 2017年07月11日 20:45, Heiko Stübner wrote:
> Hi Mark,
>
> Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao:
>> Signed-off-by: Mark Yao <mark.yao@...k-chips.com>
>> ---
>>   Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4
>> ++++ 1 file changed, 4 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
>> 9eb3f0a..11fa3b0 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> @@ -8,8 +8,12 @@ Required properties:
>>   - compatible: value should be one of the following
>>   		"rockchip,rk3036-vop";
>>   		"rockchip,rk3288-vop";
>> +		"rockchip,rk3368-vop";
>> +		"rockchip,rk3366-vop";
>>   		"rockchip,rk3399-vop-big";
>>   		"rockchip,rk3399-vop-lit";
>> +		"rockchip,rk322x-vop";
> please don't use wildcards in devicetree compatibles. We've somehow
> standardized on using rk3228 for both the rk3228 and rk3229 (which are
> nearly the same soc with some speed adjustments)
>
> So,
> +		"rockchip,rk3228-vop";
> please
>
>
> Thanks
> Heiko

Got it, I will fix it at next version

Thanks
Mark

>
>> +		"rockchip,rk3328-vop";
>>
>>   - interrupts: should contain a list of all VOP IP block interrupts in the
>>   		 order: VSYNC, LCD_SYSTEM. The interrupt specifier
>
>
>
>