linux-kernel - Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h1splk6nx.wl-tiwai@suse.de>
Date:   Wed, 12 Jul 2017 17:37:38 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Sebastian Reichel" <sebastian.reichel@...labora.co.uk>
Cc:     "Tony Lindgren" <tony@...mide.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Sebastian Reichel" <sre@...nel.org>,
        <alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>
Subject: Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec

On Wed, 12 Jul 2017 17:18:43 +0200,
Sebastian Reichel wrote:
> 
> +/* Capture Gain Control: 0dB to 31dB in 1dB steps */
> +static DECLARE_TLV_DB_SCALE(mic_gain_tlv, 0, 100, 0);
> +
> +/* Playback Gain Control: -33dB to 12dB in 3dB steps */
> +static DECLARE_TLV_DB_SCALE(vol_tlv, -3300, 300, 0);

Better to set const for TLV declarations here...

> +static const char * const cpcap_phase_invert_texts[] = {
> +	"Non Inverted", "Inverted"
> +};
> +static const SOC_ENUM_SINGLE_DECL(cpcap_hifi_l_phase_inv_enum,
> +	CPCAP_REG_RXSDOA, CPCAP_BIT_MONO_DAC0, cpcap_phase_invert_texts);
> +static const SOC_ENUM_SINGLE_DECL(cpcap_ext_l_phase_inv_enum,
> +	CPCAP_REG_RXEPOA, CPCAP_BIT_MONO_EXT0, cpcap_phase_invert_texts);

... while SOC_ENUM_*_DECL() already contain const, so you should omit
const here.


thanks,

Takashi